新增TextRank算法 #42
Closed
新增TextRank算法 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
添加新特性 1. 添加原生的TextRank算法；
|
非常感谢你的pr，由于这个周末带我妈出去玩，一直没时间弄这个。我这两天尽快把这个给merge了。 |
| } | ||
|
|
||
| /* normalize */ | ||
| double max_rank = max_element(ws.begin(), ws.end())->second; |
There was a problem hiding this comment.
这里的代码有问题吧？
- 这里排序比较的应该是 first 值而你想要的却是 second值。
- 当ws为空的时候，这个会出现不符合预期，甚至coredump的情况的。
There was a problem hiding this comment.
first是Key，在ws这个map里也就是词word, second是value，也就是单词的投票得分word score，stl的map是有就Update，没有就Insert，应该不会出现ws为空的情况下coredump的情况吧？
There was a problem hiding this comment.
我说的是99行，就是 max_element 那行，和update或者insert没有关系啊。你回复的好像和我说的不是一回事，还是我没理解对？
|
@BruceZhaoR 谢谢提醒。这个pr挺好的，可惜当时我指出一些潜在bug之后作者继续修复了。没有达到一个可用merge的状态。我找时间再review一下这个pr，尽可能修改到可merge的状态吧。 |
|
再review了一下代码，目前还存在不少问题和明显bug，该pr的作者好像已经很久没有在github上活动了。所以这个pr暂且先close掉了。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加新特性