Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimization, 初步优化线程池线程模板支持可变参数 #15

Merged
merged 2 commits into from
Feb 3, 2018

Conversation

smithnote
Copy link

@smithnote smithnote commented Feb 2, 2018

你好,我将线程池模块中,线程工作函数添加了c++11的可变模板参数的支持,这样就不用写一堆的模板了。当然还有一些不足,比如不能传引用,普通函数和类的函数的调用函数接口分开未合并

@@ -10,6 +17,77 @@ class ClosureInterface {
virtual void Run() = 0;
};

#if __cplusplus >= 201103L

/// TODO:参考std::thread, 1. 这两个类应该可以合成一个类
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

代码里面注释尽量写英文的?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, 修改了。平时习惯用中文注释项目了...

@yanyiwu yanyiwu merged commit 1c8e86f into yanyiwu:dev Feb 3, 2018
@yanyiwu
Copy link
Owner

yanyiwu commented Feb 3, 2018

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants