-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ignore
option to ignore files from build
#68
feat: add ignore
option to ignore files from build
#68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also update README.md to document the new setting
Done and I made changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
ignore
option to ignore files while building
ignore
option to ignore files while buildingignore
option to ignore files from build
@Mikescops Tests are failing: https://github.com/yao-pkg/pkg/actions/runs/9320724918/job/25736985706?pr=68#step:8:25 I think the problem is that pnpm has dropped support for nodej 16 and we don't specify a specific pnpm version so it installs latest and so that error. Could you fix please? |
@robertsLando done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are still failing and this time I think it's related to your changes:
https://github.com/yao-pkg/pkg/actions/runs/9351769172/job/25738734963?pr=68#step:8:41
There is a last error unrelated to this PR, still concerning pnpm, on windows that fails. If you have ideas. https://github.com/yao-pkg/pkg/actions/runs/9353352423/job/25743740134 |
@Mikescops EINVAL suggests there is a wrong argument passed to the command, I'm not a windows guy so I cannot help much here but I maybe for some reason npx on widows doesn't correctly parse the |
So But the |
Found this: nexe/nexe#1091 will try |
We got there 😅 thanks |
Thanks to you 🙏🏼 |
@robertsLando can you tag a new release with the change? thanks 🙏 |
Sure, 5.12.0 it's coming now |
Fixes #67
This is an attempt to solve the issue #67 by adding a new option in pkg called
ignore
, it let's define regex paths that will avoid files matching them to be included in the final bundle.Feel free to add comments and suggestions on how to improve the logic, I have included a simple test as a demo.