-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make output less verbose #31
Comments
@yargalot: pehaps this should be implemented in AccessSniff instead? It just too long now compared to other tools. See https://travis-ci.org/mpc-hc/mpc-hc.org/builds/110557334#L1012 |
Closes #13 and yargalot/grunt-accessibility#31
Ok new version should fix this, @XhmikosR can you reinstall it with the patch and see what it outputs? |
Now it is less verbose, indeed. One minor change; I'd remove the newline before the success message and follow the same scheme all the grunt plugins use with I wonder if it's possible to speed the whole process by running one time AccessSniff. |
Yep makes sense, On the performance end, there are probably some easy wins there But im more thinking its the phantomjs bootup that takes the most time. Need to look more into it |
Whoops hit the wrong button and submitted the comment before its finished. But anyway, yeh lets move this to the accessSniff repo, will have to investigate more. |
@yargalot: this is valid again :/ |
kk, looking now |
I'm thinking, this will be much easier to fix if performance was improved. At the moment, the best you can do is not show anything, which isn't good either since it takes a couple of minutes for the task to run. |
Ok, just pushed a new version of the grunt plugin to fix this, should be good to go. Tested it a local repo of the mpc site ;) |
@XhmikosR The performance is pretty bad atm, Im thinking if we could open the phantomjs instance, leave it open and fee new sites to it that would be a lot better. Only problem is Im unsure on how to do this atm, so need to look into it |
Almost there :P
|
Lol |
Ah the defaults from accessSniff merge with the options you pass in the grunt plugin. Ill change the defaults and release it. Two secs |
Ok thats fixed with the new release of AccessSniff @XhmikosR 😄No more ghost reports |
I see, thanks! |
Example:
Passing
--verbose
should show all the info, but by default, that info is just extra bloat.I can have a look when I have some time, unless someone else beats me to it.
The text was updated successfully, but these errors were encountered: