-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: entrypoint specified in module
#156
base: master
Are you sure you want to change the base?
fix: entrypoint specified in module
#156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I haven't been able to reproduce the reported problem due to vite
changes, but looked at the documentation and files and agree this change mades the (legacy) module
field as intended.
As a sanity check I looked at what some of the other Yargs libraries have, and import entry point and https://github.com/yargs/cliui/blob/af3145da0ea31738c4715865a6da0ee388a94c74/package.json#L6-L16 |
I note you put (I don't have much experience with bundlers and interested in your reasoning.) |
@shadowspawn I added it because this PR may break environments using older versions of bundlers that don't support the I checked when webpack and rollup started supporting exports.
|
Thanks for info, and good links. I found a couple of links covering background and usage of the "module" main field: |
Thank you for letting me know!
Now, my idea...
I respect your decision. |
module
module
This PR fixes #155.
I made the entrypoint specified in the
module
field the same asexports
.