Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camel-Case-Expansion: alias by Property names, not Pathes #131

Conversation

iilei
Copy link
Contributor

@iilei iilei commented Aug 22, 2018

This fixes issue #77
This is a breaking change

This fixes issue yargs#77
This *is* a breaking change
@iilei iilei force-pushed the issue_77_combined_dot_notation_and_camel_case_expansion branch from 6763c93 to 3133b46 Compare August 22, 2018 19:28
@bcoe
Copy link
Member

bcoe commented Oct 6, 2018

@iilei thank you for this contribution ... while this is a breaking change, it feels like it's definitely addressing a bug (and I can't imagine many folks in yargs relying on the old behavior). My temptation is to call it a breaking change in yargs-parser, but to make it a patch in yargs ... then there's a paper trail for folks if it does break anyone, but we don't release a new yargs major.

@bcoe bcoe merged commit dc788da into yargs:master Oct 6, 2018
@iilei
Copy link
Contributor Author

iilei commented Oct 6, 2018

@bcoe thank you for merging.

My temptation is to call it a breaking change in yargs-parser, but to make it a patch in yargs

I would tend to do the same, for the same reasons. I can imagine it is more likely people have worked around it using aliases rather than relying on it. But that's just my uneducated guess

@bcoe
Copy link
Member

bcoe commented Oct 6, 2018

@iilei this is now available in npm i yargs@next mind taking it for a spin and letting me know if things work alright?

@iilei
Copy link
Contributor Author

iilei commented Oct 7, 2018

@bcoe here is a code-kata repository / branch on which I verified it works:

https://github.com/iilei/kata-boilerplate/commit/0f244788b6eb246982123fbe9a8827323486ce13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants