Ensure empty string is added into argv._ #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, a string such as "hello '' world" would parse into ["hello", undefined, "world"]. This adds a catch for that, ensuring that an empty string is pushed instead, and adds associated tests.
bcoe
reviewed
Nov 8, 2018
lib/tokenize-arg-string.js
Outdated
| @@ -17,6 +17,7 @@ module.exports = function (argString) { | |||
| // split on spaces unless we're in quotes. | |||
| if (c === ' ' && !opening) { | |||
| if (!(prevC === ' ')) { | |||
| if (!args[i]) args[i] = '' | |||
There was a problem hiding this comment.
👋 for this fix, I think it would make sense to move the logic down to the check for the closing quote. So something like:
if (c === opening) {
if (!args[i]) args[i] = ''
opening = null
continue
}
There was a problem hiding this comment.
I see how that would make sense - placing it at the point of detecting the closing quotes. Both ways pass the tests, so I'll commit the change.
The reason I put it where I did was to ensure that we can't possibly increment i before we've checked for a missing argument.
There was a problem hiding this comment.
Committed :)
|
@jacksdrobinson thank you for the contribution, left a comment. |
This issue concerns when arguments are undefined due to empty quoted strings. Therefore, it makes sense to place the check for an undefined argument into the block which detects the closing quotes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A string such as "hello '' world" would parse into ["hello", undefined, "world"].
This would add a catch for that, ensuring that an empty string is pushed
instead, and adds associated tests.