Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(extensions): eslint-import-resolver-vite@<2.0.1 #6154

Merged
merged 4 commits into from
Mar 10, 2024
Merged

fix(extensions): eslint-import-resolver-vite@<2.0.1 #6154

merged 4 commits into from
Mar 10, 2024

Conversation

n0099
Copy link
Contributor

@n0099 n0099 commented Mar 6, 2024

What's the problem this PR addresses?

pzmosquito/eslint-import-resolver-vite#22

How did you fix it?

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

merceyz
merceyz requested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@merceyz merceyz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yarn, along with the other package managers, ignores devDependencies of dependencies.

packages/yarnpkg-extensions/sources/index.ts Outdated Show resolved Hide resolved
@n0099 @merceyz
Update packages/yarnpkg-extensions/sources/index.ts
04ca522 
Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
@merceyz merceyz changed the title Update @yarnpkg/extensions for eslint-import-resolver-vite@<2.0.1 fix(extensions): eslint-import-resolver-vite@<=2.0.1 Mar 6, 2024
merceyz
merceyz previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@merceyz merceyz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@merceyz merceyz enabled auto-merge March 6, 2024 18:44
@merceyz merceyz disabled auto-merge March 6, 2024 18:47
@merceyz merceyz changed the title fix(extensions): eslint-import-resolver-vite@<=2.0.1 fix(extensions): eslint-import-resolver-vite@<2.0.1 Mar 6, 2024
@merceyz merceyz enabled auto-merge March 6, 2024 18:48
@arcanis arcanis disabled auto-merge March 10, 2024 09:21
@arcanis arcanis merged commit 2d6a7ab into yarnpkg:master Mar 10, 2024
20 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merceyz merceyz merceyz approved these changes

@arcanis arcanis arcanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n0099 @arcanis @merceyz