Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
When using the
-R
flag on a flag with a large amount of workspaces,yarn why
may fail to return enough information to answer the question "why is this package here". This is because of a bug in the implementation where we decline to print a package in the tree view if:However we check the first condition first and we put the package in the "seen" list before we check whether it's a workspace. As a result, workspaces that are dependencies of other workspaces won't have their dependencies shown.
How did you fix it?
Flipped the two conditions.
Checklist