Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore all JSON files in linting config #6386

Closed
wants to merge 1 commit into from

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jul 7, 2024

What's the problem this PR addresses?

The pattern I added in #6352 only worked on the root JSON files.

How did you fix it?

Update the pattern to match all JSON files

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@clemyan
Copy link
Member

clemyan commented Jul 17, 2024

I don't think this is the correct fix. See #6357

@merceyz
Copy link
Member Author

merceyz commented Jul 24, 2024

It worked as a quick fix but since your PR is more complete and has been merged I'll close this.

@merceyz merceyz closed this Jul 24, 2024
@merceyz merceyz deleted the merceyz/chore/ignore-all-json-in-linting branch July 24, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants