Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanups some tests #6388

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Cleanups some tests #6388

merged 3 commits into from
Jul 29, 2024

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented Jul 8, 2024

What's the problem this PR addresses?

I'm reviewing our tests and came upon some of them that could be dumbed down. I prefer to make them test as little things as possible to avoid something breaking due to unrelated parts of the code changing (I'm working on switching some implementations, and limiting test dependencies make things considerably easier / more fun to work on).

How did you fix it?

No big changes - it's mostly things like using the dependencies rather than calling yarn add and avoiding to rely on cache paths to check whether something got properly installed.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit dca729d into master Jul 29, 2024
22 of 26 checks passed
@arcanis arcanis deleted the mael/test-cleanup branch July 29, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant