-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress bar doesn't render correctly in Visual Studio Code's terminal panel #1222
Comments
On my machine ,all displays incorrect,including cmd, powershell, gitbash. |
I'm pretty sure this just means VS Code is not processing the It's not a Windows issue, a PowerShell or Cmd.exe issue, nor a font issue. If this is indeed the problem, I would file the issue with them (VS Code), not Yarn. However, Yarn should have an option to disable the progress bar for improved compatibility if it doesn't already. |
@mnpenner - It uses readline.cursorTo to reposition the cursor at the start of the line, which internally uses ANSI escape codes. |
I found a way to avoid this problem on my Chinese win 10 terminal, that is to set the "Active Code Page" to 437(us-en) or 65001(UTF-8).Just type Yarn is fine, VS code is fine, windows old terminal's charset's bad! |
@redstrike I disagree, whilst it's not broken as hell. It's still not perfect, it's too large and still has some areas that "stick" around for a little while before disappearing. It's really hard to describe without recording it. |
I'm seeing a similar issue on some but not all Linux hosts: Strace shows that yarn emits Some digging lead me to the It looks like this is a bug in yarn (or whatever yarn uses for the progress bar); not emitting the cursor-moving control sequences when an optional environment variable is missing. If all else fails, may I suggest simply using |
There is similar issue with Jest: jestjs/jest#3626 |
Another glitch with yarn in VS Code: microsoft/vscode#24604 |
Apparently, it is not Yarn issue: microsoft/vscode#19665 |
unfortunately "KB4020102" did not fix the issue for me . |
@mmoreaux
This would be Node.js' readline.cursorTo function. |
Progress bar is now fixed for me after installing KB4020102 and updating VS Code to 1.13.0 |
It seems that Unicode character width improvements in VS Code 1.13 has fixed this issue. |
|
No, the issue cannot be closed; the issue @xakep139 started talking about is different from the issue described in the starting post (different type of corruption, and the issue from the OP also happens on non-Windows hosts). |
I can confirm this bug appears on OS X and Linux just like the other screenshots/videos with the Keras Progbar on 1.13.1. |
This bug still happens with Yarn 1.0.1 in Windows 10 (PowerShell and cmd) with some fonts. |
I think this is a duplicate of #2530, right? |
@redstrike I was afraid of this when I wrote that comment! :D It is also obvious from the issue numbers that this is the "original" issue. That said the other one has a PR attached and it is more generic so I was implying that closing this in favor of that. If you are too attached to this one, we can close them at once with the PR though :D |
Thank you for your support. We can close this issue to ease your management efforts. |
Will do :) |
This was fixed by #4317. |
Do you want to request a feature or report a bug?
Not sure.
What is the current behavior?
yarn is very buggy, slow while running. And the progress bar auto line breaks itself looks ugly.
If the current behavior is a bug, please provide the steps to reproduce.
yarn install / yarn upgrade
What is the expected behavior?
A progressive and good looking progress bar.
Please mention your node.js, yarn and operating system version.
This bug still happens until now 2017/05/15:
The text was updated successfully, but these errors were encountered: