Issues with node-gyp, node-mdns, node 6.9.1 and osx 10.12 Sierra

[hugohil]

Hi!

I tried using yarn to install node-mdns, and got these issues with node-gyp:

In file included from ../src/dns_sd.cpp:1:
In file included from ../src/mdns.hpp:12:
../../nan/nan.h:602:20: error: no type named 'GCEpilogueCallback' in 'v8::Isolate'
      v8::Isolate::GCEpilogueCallback callback
      ~~~~~~~~~~~~~^
../../nan/nan.h:608:20: error: no type named 'GCEpilogueCallback' in 'v8::Isolate'
      v8::Isolate::GCEpilogueCallback callback) {
      ~~~~~~~~~~~~~^
../../nan/nan.h:613:20: error: no type named 'GCPrologueCallback' in 'v8::Isolate'
      v8::Isolate::GCPrologueCallback callback
      ~~~~~~~~~~~~~^
../../nan/nan.h:619:20: error: no type named 'GCPrologueCallback' in 'v8::Isolate'
      v8::Isolate::GCPrologueCallback callback) {
      ~~~~~~~~~~~~~^

After brew upgrade, I was able to run it with npm, which is why I'm posting this issue here and not on the node-mdns repository.

Darwin 16.0.0 (OS X 10.12)
node -v v6.9.1
node-gyp -v v3.4.0

Any idea on what might cause this ?
Thanks!

[wyze]

What version of yarn are you using? And is this with a yarn add or yarn install?

[hugohil]

I'm using yarn 0.16.1 and the yarn add command.

[wyze]

Can you upgrade to the latest yarn version (0.17.8) and try again? I was able to run yarn add mdns successfully.

[hugohil]

Indeed, I was too ! Sorry for for the time.

[wyze]

No worries!