upgrade-interactive row colours are incorrect

[jesstelford]

Bug report

Current behaviour:

Reproduction steps:

Have a repo with various out of date packages, and run yarn upgrade-interactive to see the incorrect colours applied to the rows.

Expected behaviour:

• @domain-group/eslint-config-domain, @domain-group/fe-brary & @domain-group/fe-build should be neither red nor yellow - they have a major version bump with API incompatible changes.
• babel-core should be yellow as it is a minor update.

Environment:

$ yarn --version
0.27.5
$ node --version
v7.10.0
$ system_profiler SPSoftwareDataType
Software:

    System Software Overview:

      System Version: OS X 10.10.5 (14F2411)
      Kernel Version: Darwin 14.5.0

[BYK]

Hi @jesstelford - Can you provide a package.json or a small test repo/gist so we can reliably reproduce this.

[lirantal]

I'm observing similar color/definition inconsistencies for my project at https://github.com/lirantal/dockly so you can easily reproduce using it's package.json file:

[carlrosell]

I created a small repository with eslint@^3.18.0 as the only dependency https://github.com/CarlRosell/yarn-upgrade-interactive. The lock file is from another repository at work. The one that bit me and made me look for issues was react-router 3.0.2 > 4.1.2:

[rally25rs]

You know, last time I was in the upgrade-interactive code I thought the function that determined colors looked a little suspect, but I didn't change it because I assumed it must have been right.

yarn/src/cli/commands/upgrade-interactive.js

Line 60 in 116275c

const colorizeName = ({current, wanted}) => (current === wanted ? reporter.format.yellow : reporter.format.red);

That doesn't seem to do anything to check the parts of the versions.

[BYK]

Was able to reproduce with the following:

git clone git@github.com:lirantal/dockly.git
cd dockly
yarn upgrade-interactive

I think this is quite broken. I also think the legend should be as follows:

• Green: patch
• Yellow: minor
• Red: major

Thoughts?