Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi i'm color Color blindness #5800

Closed
Loyide opened this issue May 9, 2018 · 7 comments

Comments

Projects
None yet
6 participants
@Loyide
Copy link

commented May 9, 2018

i'm color blindess so when use yarn outdated

I can't distinguish the difference between green and yellow

 yarn outdated
yarn outdated v1.6.0
info Color legend :
 "<red>"    : Major Update backward-incompatible updates
 "<yellow>" : Minor Update backward-compatible features
 "<green>"  : Patch Update backward-compatible bug fixes

@ghost ghost assigned rally25rs May 9, 2018

@ghost ghost added the triaged label May 9, 2018

@rally25rs

This comment has been minimized.

Copy link
Contributor

commented May 9, 2018

Hi @Loyide 👋 Pardon my lack of knowledge with this particular accessibility concern, but is there a better color combination that you can recommend? We use chalk.js so the other color options can be viewed there.

I also believe the "yellow" and "green" come from the color settings of your terminal, so changing color settings there might be another more universal approach that would cover other applications that use colored output.

In this particular case the colors are just a secondary indicator of which digit in the semver (major, minor, patch) is different, and that information is also communicated by displaying the actual semver ranges themselves, so I hope this hasn't prevented you from using upgrade-interactive.

I'll mark this as a feature request to improve accessibility. Thanks for your feedback!

@Loyide

This comment has been minimized.

Copy link
Author

commented May 10, 2018

For people like me, red, yellow and blue are much better combinations than
red, yellow, and green combinations.

So I would like to recommend the blue family!

For your information
There are many kinds of color blindness.
Some of them can not distinguish between green and yellow.
So the colors of the traffic lights can be confusing.

Thank you for your feedback!
Have a great day!

ohbarye added a commit to ohbarye/yarn that referenced this issue May 16, 2018

ohbarye added a commit to ohbarye/yarn that referenced this issue May 16, 2018

@sth

This comment has been minimized.

Copy link
Contributor

commented May 21, 2018

I feel green intuitively conveys "should cause no problems when upgrading", much more so than blue. So isn't green in general the better color for this?

How the colors actually look is very much dependent on the terminal you use (light or dark background, color scheme). Usually that can be configured by the user (though I don't know if it is possible on windows). Also there are different kinds of color blindness where different pairs of color are hard to distinguish.

Wouldn't it be a much better solution for the user to configure their terminal with a color scheme that is accessible by them? That would not only fix their problems for this yarn command, but for all terminal programs.

@BYK

This comment has been minimized.

Copy link
Member

commented May 23, 2018

Wouldn't it be a much better solution for the user to configure their terminal with a color scheme that is accessible by them? That would not only fix their problems for this yarn command, but for all terminal programs.

As a deutan myself I can totally relate to the author. That said since there are other types of color blindness, especially ones like tritanopia who would actually suffer from a change like #5829, I think the best is to leave this to the end user's terminal color settings.

What do you think @Loyide and @ohbarye?

@ohbarye

This comment has been minimized.

Copy link
Contributor

commented May 23, 2018

@sth @BYK
Thanks for your opinion!

I first thought my change saves someone who feels isolated from the world due to lack of consideration of them. And yarn would be a more accessible tool for more people. But I didn't know it causes another issue and there seems no perfect solution for everyone.

I'm not color blindness, it means that I cannot totally understand how/what you feel on yarn's color selection. So if insiders, like you, say that's okay, I entirely respect your voice. 👍

Feel free to close #5829 !

@BYK

This comment has been minimized.

Copy link
Member

commented Jun 5, 2018

Since I haven't heard much from anyone else, I'll go ahead and close this issue along with the pull request. Thanks a lot for raising awareness about this and all the effort!

@BYK BYK closed this Jun 5, 2018

@milesj

This comment has been minimized.

Copy link

commented Jun 5, 2018

I looked into something like this for another project of mine. I ended up going with themes (through something like --theme) instead of specific color blindness support. https://github.com/milesj/boost/blob/master/src/themes.ts

You can then use the hexcodes directly with chalk: https://github.com/milesj/boost/blob/master/src/Reporter.ts#L433 This feature does require true color support in the terminal however.

For all other instances where this isn't possible, it should probably be up to the users terminal settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.