Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect global option for config add and config delete #1039

Closed

Conversation

FLGMwt
Copy link
Contributor

@FLGMwt FLGMwt commented Oct 14, 2016

Summary
Global option for yarn config is documented, but unimplemented.

Test plan

> yarn config list
yarn config v0.15.1
info yarn config
{ 'version-tag-prefix': 'v',
  'version-git-tag': true,
...
PS C:\Program Files\nodejs> yarn config set ".some-key" "user value"
yarn config v0.15.1
success Set ".some-key" to "user value".
Done in 0.03s.
PS C:\Program Files\nodejs> yarn config set ".some-key" "global value" -g
yarn config v0.15.1
success Set ".some-key" to "global value".
Done in 0.04s.
PS C:\Program Files\nodejs> cat .\.yarnrc
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
# yarn lockfile v1
".some-key" "global value"
PS C:\Program Files\nodejs> cat ~/.yarnrc
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
# yarn lockfile v1
".some-key" "user value"
> yarn config list
yarn config v0.15.1
info yarn config
{ '.some-key': 'global value',
...

@FLGMwt
Copy link
Contributor Author

FLGMwt commented Oct 14, 2016

FYI example output shows global value favored over user value. I address this in #951

@FLGMwt
Copy link
Contributor Author

FLGMwt commented Oct 14, 2016

Fixes #1037

@bestander
Copy link
Member

I think we have yarn global add/remove since then.
Sorry for loosing this

@bestander bestander closed this Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants