Use Yarn package/installer on Travis/AppVeyor/CircleCI rather than npm #1117
Conversation
Daniel15
force-pushed
the
better-ci
branch
2 times, most recently
from
d4f38a9
to
005958b
Compare
| node_js: | ||
| - "6" | ||
|
|
||
| sudo: required # Until Yarn repo is added to apt-source-whitelist | ||
|
|
||
| addons: |
There was a problem hiding this comment.
Why not wait until you get the whitelist pass to change things over?
Won't dropping sudo make the CI runs slower?
Related to #1082.
There was a problem hiding this comment.
The whitelist seems to take a long time to get things into it, there's 225 issues and 40 pull requests right now.
CircleCI is much faster than Travis and allows sudo by default, so we're mostly relying on Circle these days instead of Travis. Travis' container infra is more limited than Circle's, Circle even lets you SSH into the build boxes to diagnose build problems.
There was a problem hiding this comment.
@jdalton: I don't see a statistically significant increase in build time, Travis builds times are all over the place. Here's a few recent builds:
- 11 mins 8 seconds before my change: https://travis-ci.org/yarnpkg/yarn/builds/167944596
- 11 mins 46 seconds after my change: https://travis-ci.org/yarnpkg/yarn/builds/167991917
- 13 mins 57 seconds before my change: https://travis-ci.org/yarnpkg/yarn/builds/167885858
- 14 mins 22 seconds after my change: https://travis-ci.org/yarnpkg/yarn/builds/167993297
- 16 mins 17 seconds before my change: https://travis-ci.org/yarnpkg/yarn/builds/167945545
There was a problem hiding this comment.
Ya, just checked myself. Neat.
Summary
On Linux:
npmbootstrap-env-ubuntu.shscript. The more of the environment configuration we have in here, the better (as it'll make it easier to have Docker/Vagrant images for Yarn dev/build in the future)On Windows (AppVeyor):
Test plan
Will check on Travis/AppVeyor/CircleCI once PR is submitted and the build is kicked off