Switch to micromatch: fixes yarnpkg/yarn#3336

[jrop]

Summary

The micromatch library provides an inconsistent implementation of .makeRe(...) with the rest of it's interface. It is known that makeRe does not produce Regular Expressions that can be trusted:

• Glob patterns with ** are not properly converted to regular expressions isaacs/minimatch#67
• do not use minimatch.makeRe since it is broken, instead use minimatch() default function (T6877) babel/babel#3914

This PR switches from minimatch => micromatch.

Motivation: #3336 😄

Test plan

TODO:

• Update tests and make them pass (before merge)

Tested so far:

$ alias my_yarn='node /github/yarn/lib/cli/index.js'
$ cd /my/other/project
$ my_yarn pack
$ tar -tf my-package-v1.0.0.tgz
#
# Output is as expected
#

[jrop]

Unpredictable tests on Travis fail with "timeout" errors:

Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
      
      at ontimeout (timers.js:386:14)
      at tryOnTimeout (timers.js:250:5)
      at Timer.listOnTimeout (timers.js:214:5)

This failure does not seem to be related to this PR, am I correct?

[bestander]

Nice, thanks for a thorough explanation, tests and fix

[jrop]

@bestander 😰 I just realized that the way I added the extra test causes it to fail on windows in AppVeyor, because I hard coded the path separator lib/a.js for example. On windows the test fails because the path will be lib\a.js. I pushed one more commit that changes the test to use path.join('lib', 'a.js'). Does it need another PR?

[bestander]

Yeah, could you send a new PR?

[bestander]

@jrop when to expect the PR?
I'd like to cut 0.25 release

[jrop]

@bestander Just submitted. Sorry about that ☹️

[bestander]

no worries :)