Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified yarn link Warning #6106

Merged
merged 2 commits into from
Jul 19, 2018
Merged

Clarified yarn link Warning #6106

merged 2 commits into from
Jul 19, 2018

Conversation

irrationalRock
Copy link
Contributor

Summary
This PR fixes #5991.

The message for linkCollision is now:

There's already a package called $0 registered. This command has had no effect. If this command was run in another folder with the same name,  the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.

Motivation
As mentioned in the issue, the current warning for yarn link is vague and should be more specific.

Test plan
When running yarn link, it produces this warning now:

warning There's already a package called "rimraf" registered. This command has had no effect. If this command was run in another folder with the same name, the other folder is still linked. Please run yarn unlink in the other folder if you want to register this folder.

@arcanis arcanis merged commit a9e61f7 into yarnpkg:master Jul 19, 2018
@arcanis
Copy link
Member

arcanis commented Jul 19, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running yarn link multiple times return non clear message
2 participants