Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes offline mirror filename calculation for scoped packages URLs in Verdaccio (private npm repository) #7499

Merged
merged 3 commits into from
Sep 1, 2019

Conversation

xv2
Copy link
Contributor

@xv2 xv2 commented Aug 28, 2019

Fixes for tarball contains %2f instead of /
Sample: http://npm.xxxyyyzzz.ru/@types%2fevents/-/events-3.0.0.tgz
Issue: #7498

@arcanis arcanis merged commit b8af7e0 into yarnpkg:master Sep 1, 2019
@arcanis
Copy link
Member

arcanis commented Sep 1, 2019

Sounds reasonable - thanks!

@c10b10
Copy link

c10b10 commented Nov 25, 2019

Has this been released? Which version?

@xv2
Copy link
Contributor Author

xv2 commented Nov 25, 2019

@c10b10 This fix was integrated in 1.18.0, but I recommend using latest version (v.1.19.1)

VincentBailly pushed a commit to VincentBailly/yarn that referenced this pull request Jun 10, 2020
… Verdaccio (private npm repository) (yarnpkg#7499)

* Fixes offline mirror filename calculation for scoped packages URLs in Verdaccio (private npm repository)

* Fixed test

* Update CHANGELOG.md
VincentBailly pushed a commit to VincentBailly/yarn that referenced this pull request Jun 10, 2020
… Verdaccio (private npm repository) (yarnpkg#7499)

* Fixes offline mirror filename calculation for scoped packages URLs in Verdaccio (private npm repository)

* Fixed test

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants