[WIP] - Upgrade flow to 0.75.0 #7856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olingern
commented
Jan 30, 2020
| @@ -17,6 +17,7 @@ export type Tree = { | |||
| hint?: ?string, | |||
| hidden?: boolean, | |||
| color?: ?string, | |||
| shadow?: ?String, | |||
There was a problem hiding this comment.
String should be string
olingern
commented
Jan 30, 2020
| @@ -610,6 +612,7 @@ export class Install { | |||
| steps.push((curr: number, total: number) => | |||
| callThroughHook('auditStep', async () => { | |||
| this.reporter.step(curr, total, this.reporter.lang('auditRunning'), emoji.get('mag')); | |||
|
|
|||
olingern
commented
Jan 30, 2020
| if (typeof params.cleanup === 'function') { | ||
| params.cleanup(); | ||
| } | ||
|
|
||
| opts.retryReason = reason; |
There was a problem hiding this comment.
It's unclear whether this was ever used anywhere. I could not find any traces of request-manager having a cleanup function bound to its options, but I'll do one more pass just make sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently a work in progress. A few more errors to fix and I may bump the version a bit more if not too many changes are required. There are a lot of open PR's so I want rebasing to be as easy as possible while ensuring any new code is not taking any steps backwards in terms of typing / soundness.
Before I finish up #7848, I wanted some sanity for the code I was writing + a working language server for vscode. This is a minimal upgrade to
v0.75.0. Attempting to get tov0.117.0appears to be quite painful. Any assistance from the flow team is welcome 🙂Test plan
yarn lintreturns no errors