fix(pack): sort files to produce identical output on Windows and Unix #8142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Running
yarn pack
on Windows and Unix systems produce different results, since on Unix systems the files are sorted while on Windows they aren't.Running
yarn pack
on https://github.com/arcanis/babel-plugin-lazy-import produces this output on WindowsWhile on Unix it produces
This PR fixes this by telling
tar-fs
to sort the files before it packs them.yarn pack
also included the.yarnrc.yml
config file so I added it to theDEFAULT_IGNORE
list.Test plan
Run
yarn pack
in a repository containing multiple files and check that the output oftar -ztf package.tgz
is the same on Windows and Unix