New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ReqMeta.TTL in favor of Context.Timeout #182

Closed

HelloGrayson opened this issue Jun 3, 2016 · 1 comment

Milestone

Contributor

HelloGrayson commented Jun 3, 2016 •

edited

Loading

Having a separate TTL concept is a bit surprising:

 yarpc.ReqMeta(
    Context: context.WithTimeout(time.Second),
    TTL: time.Second,
    ...
)

Instead, lets start with just the context timeout.

cc @yarpc/golang

HelloGrayson mentioned this issue

Add support for outbound TTL to HTTP and TChannel #181

Merged

HelloGrayson added this to the Finalize API milestone

Contributor Author

HelloGrayson commented Jun 7, 2016

Fixed in #192

kriskowal closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment