Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eradicate ReqMeta.TTL #192

Merged
merged 1 commit into from
Jun 7, 2016
Merged

Eradicate ReqMeta.TTL #192

merged 1 commit into from
Jun 7, 2016

Conversation

kriskowal
Copy link
Contributor

@kriskowal kriskowal commented Jun 7, 2016 •
edited
Loading

HENCEFORTH the context shall be the single source of truth for the request TTL and Deadline.
WHEREAS N’er shall this value also be expressed as a property of the request metadata
EXCEPT INSOFARAS there may one day be a per attempt timeout
THAT SHALL be used to clamp each attempt from the time it starts.
So say we all.

r @yarpc/golang

abhinav
abhinav reviewed Jun 7, 2016
View reviewed changes
internal/request/validator.go
}

// ParseTTL parses the given TTL and updates the request's TTL value.
func (v *Validator) ParseTTL(ttl string) {
func (v *Validator) ParseTTL(ctx context.Context, ttl string) (context.Context, func()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the docs on what this returns?

@abhinav
Copy link
Contributor

abhinav commented Jun 7, 2016

🎉

LGTM besides nits

@HelloGrayson
Copy link
Contributor

ty sir 🚢

@kriskowal kriskowal force-pushed the yuttl branch 2 times, most recently from e5e1189 to ae5996e Compare June 7, 2016 17:05
@HelloGrayson
Copy link
Contributor 

# github.com/yarpc/yarpc-go/transport/tchannel
transport/tchannel/handler_test.go:125: cannot use time.Second (type time.Duration) as type transporttest.ContextMatcherOption in argument to transporttest.NewContextMatcher
transport/tchannel/handler_test.go:162: cannot use time.Second (type time.Duration) as type transporttest.ContextMatcherOption in argument to transporttest.NewContextMatcher
FAIL    github.com/yarpc/yarpc-go/transport/tchannel [build failed]
make: *** [test_ci] Error 2

@abhinav
Copy link
Contributor

abhinav commented Jun 7, 2016

Oh yeah. @kriskowal you'll have to use the API added in #190

@kriskowal
Copy link
Contributor Author

Waiting for CI again. Rebased on master and updated the ContextMatcher usage.

@HelloGrayson HelloGrayson mentioned this pull request Jun 7, 2016
Closed
@kriskowal kriskowal merged commit 5e23116 into master Jun 7, 2016
@kriskowal kriskowal deleted the yuttl branch June 7, 2016 17:41
@HelloGrayson
Copy link
Contributor

🎈

vyshah pushed a commit that referenced this pull request Nov 14, 2018
@abhinav
Add canonical import path (#192)
45540ff 
This adds the canonical import path directive so that people don't
try to import this as github.com/uber-go/dig and see cryptic error
messages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kriskowal @abhinav @HelloGrayson