[1/2 tchannel refactoring] Extracted response writer to dedicated file. #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype and simplified interface
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## emit-metrics-for-new-behavior-step-1 #2273 +/- ##
========================================================================
- Coverage 85.33% 85.31% -0.02%
========================================================================
Files 271 272 +1
Lines 15624 15630 +6
========================================================================
+ Hits 13333 13335 +2
- Misses 1872 1874 +2
- Partials 419 421 +2 ☔ View full report in Codecov by Sentry. |
AllenLuUber
reviewed
May 8, 2024
| AddHeader(key string, value string) | ||
| transport.ResponseWriter | ||
|
|
||
| AddSystemHeader(key string, value string) |
There was a problem hiding this comment.
optional: do you want to use AddTransportHeader instead, as usually we differentiate between transport header and application header. System sounds quite general.
There was a problem hiding this comment.
AddSystemHeader is used in grpc, so I decided to make it consistent at first step (: Maybe we'll return to this and change to AddTransportHeader in a future refactoring, as it makes sense to me.
AllenLuUber
approved these changes
May 8, 2024
biosvs
merged commit d8e451e
into
emit-metrics-for-new-behavior-step-1
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted response writer to dedicated file, introduced constructor type and simplified interface.
This PR is part of header handling changes (#2265). This refactoring was extracted from tchannel PR to make review easier.