Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sdump and SdumpNC #4

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Add Sdump and SdumpNC #4

merged 2 commits into from
Apr 2, 2024

Conversation

yassinebenaid
Copy link
Owner

No description provided.

@yassinebenaid yassinebenaid merged commit a96f590 into master Apr 2, 2024
@yassinebenaid yassinebenaid mentioned this pull request Apr 2, 2024
Closed
kokizzu
kokizzu reviewed Apr 2, 2024
View reviewed changes
godump.go
return d.buf.String()
}

// Sdump is just like DumpNC but returns the result instead of prining to STDOUT
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo printing

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this was resolved in pull#5 and pull#6

kokizzu
kokizzu reviewed Apr 2, 2024
View reviewed changes
godump.go
@@ -26,3 +26,20 @@ func DumpNC(v any) error {
}
return nil
}

// Sdump is just like Dump but returns the result instead of prining to STDOUT
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo printing

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this was resolved in pull#5 and pull#6

@yassinebenaid yassinebenaid deleted the implement-sdump-and-sdumpnc branch May 28, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kokizzu kokizzu kokizzu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yassinebenaid @kokizzu