Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bsc#1083949 #103

Closed
wants to merge 11 commits into from
Closed

Fix bsc#1083949 #103

wants to merge 11 commits into from

Conversation

varkoly
Copy link
Contributor

@varkoly varkoly commented Aug 23, 2021

Enhance translation

varkoly and others added 11 commits January 27, 2015 12:03
SLEx_15_LOC : YaST: ALL_LANGS:Untranslated text in User Logon Management/Manage Domain User Login/Active Directory Enrollment dialog
SLEx_15_LOC : YaST: ALL_LANGS:Untranslated text in User Logon Management/Manage Domain User Login/Active Directory Enrollment dialog
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1158931444

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 18.569%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/authui/sssd/main_dialog.rb 0 2 0.0%
Totals Coverage Status
Change from base Build 816302322: 0.0%
Covered Lines: 493
Relevant Lines: 2655

💛 - Coveralls

@ancorgs
Copy link
Contributor

ancorgs commented Aug 24, 2021

To be honest, I don't see why changing _("blah %s") % var) into format(_("blah %s"), var) would make any difference in terms of the referenced bug. As far as I can see, the code is completely equivalent so it would fix nothing.

@dgdavid
Copy link
Member

dgdavid commented Aug 24, 2021

To be honest, I don't see why changing _("blah %s") % var) into format(_("blah %s"), var) would make any difference in terms of the referenced bug. As far as I can see, the code is completely equivalent so it would fix nothing.

I agree.

I approved it because I though it was a merge of 4.3 in 4.4. I got confused with 9871b85, which points to 4.3.2. However, 4.3.2 is actually a different change, see https://github.com/yast/yast-auth-client/blob/SLE-15-SP3/package/yast2-auth-client.changes

Anyway, the change does not hurt. Maybe an accurate changes entry would be better, but this is up to @varkoly :)

@dgdavid
Copy link
Member

dgdavid commented Sep 13, 2021

I have talked with @varkoly via Slack. We agreed on closing this PR since @ancorgs is right.

@dgdavid dgdavid closed this Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants