bnc#965311 - yast ldap-server-ssl-check does not handle ldaps only ldap+starttls works #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce branch SLE-12-SP1
…ap+starttls works
…ap+starttls works
| lc.bind(); | ||
| exit(0); | ||
| } catch (LDAPException e) { | ||
| if (e.getResultCode() == 49) { |
There was a problem hiding this comment.
There is no error code 42. Error codes between 37 and 47 are not used.
There was a problem hiding this comment.
42, 37, 49, 47 are meaningless numbers. INVALID_CREDENTIALS is what makes code understandable.
/usr/include/LDAPResult.h: static const int INVALID_CREDENTIALS = 49;
…t returns "undefined method" error
|
That's strange, have you reverted the changes by accident? GitHub shows a nearly empty diff. |
| @@ -1,5 +1,7 @@ | |||
| require "yast/rake" | |||
|
|
|||
| Yast::Tasks.submit_to :sle12sp1 | |||
There was a problem hiding this comment.
this is wrong. It is commit only for SLE12SP1 maintenance branch. Please revert this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.suse.com/show_bug.cgi?id=965311