Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bsc1172340 #66

Merged
merged 4 commits into from
Apr 6, 2021
Merged

Bsc1172340 #66

merged 4 commits into from
Apr 6, 2021

Conversation

noelpower
Copy link
Contributor

No description provided.

@noelpower noelpower force-pushed the bsc1172340 branch 3 times, most recently from de52af3 to 1be68ac Compare November 24, 2020 10:56
textdomain "authserver"

msg = format(
_("Command line is not supported. Use '%s' directly."),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there really ldap-server and krb-server CLI commands? I do not see it. If you just do not support CLI at all and there there is no good replacement, you can omit that "help" parameter and it will just write CLI not supported.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I don't understand this comment. Can you explain what you mean here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, what I mean here. That this help text is showed when user print some command line arguments so e.g.:

yast2 auth-cli help

say use Use 'auth-cli' directly. but such command does not exists. We use it often to provide existing CLI tool that user can use e.g. for firewall we recommend firewall-cli to use. But if I get it here is not direct replacement for functionality that auth-cli provide that works on command line. So in that case I suggest to use solution we use e.g. in storage-ng where is also no suitable CLI tool and just say CLI not available - yast/yast-storage-ng#1170 (comment)

so simply you can remove that msg and "help" key from map and it will print just "CLI not supported"

src/lib/authserver/cli/auth-cli.rb Outdated Show resolved Hide resolved
Signed-off-by: Noel Power <noel.power@suse.com>
Signed-off-by: Noel Power <noel.power@suse.com>
Signed-off-by: Noel Power <noel.power@suse.com>
Signed-off-by: Noel Power <noel.power@suse.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 722258648

  • 0 of 22 (0.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 11.609%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/clients/krb-server.rb 0 5 0.0%
src/clients/ldap-server.rb 0 5 0.0%
src/lib/authserver/cli/auth-cli.rb 0 12 0.0%
Totals Coverage Status
Change from base Build 646759445: -0.5%
Covered Lines: 57
Relevant Lines: 491

💛 - Coveralls

@scabrero scabrero merged commit d6e5e7d into yast:master Apr 6, 2021
@yast-bot
Copy link

yast-bot commented Apr 6, 2021

✔️ Public Jenkins job #14 successfully finished
✔️ Created OBS submit request #883276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants