-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bsc1172340 #66
Bsc1172340 #66
Conversation
de52af3
to
1be68ac
Compare
src/lib/authserver/cli/auth-cli.rb
Outdated
textdomain "authserver" | ||
|
||
msg = format( | ||
_("Command line is not supported. Use '%s' directly."), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there really ldap-server and krb-server CLI commands? I do not see it. If you just do not support CLI at all and there there is no good replacement, you can omit that "help" parameter and it will just write CLI not supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I don't understand this comment. Can you explain what you mean here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, what I mean here. That this help text is showed when user print some command line arguments so e.g.:
yast2 auth-cli help
say use Use 'auth-cli' directly.
but such command does not exists. We use it often to provide existing CLI tool that user can use e.g. for firewall we recommend firewall-cli
to use. But if I get it here is not direct replacement for functionality that auth-cli provide that works on command line. So in that case I suggest to use solution we use e.g. in storage-ng where is also no suitable CLI tool and just say CLI not available - yast/yast-storage-ng#1170 (comment)
so simply you can remove that msg and "help" key from map and it will print just "CLI not supported"
1be68ac
to
ceedb66
Compare
Signed-off-by: Noel Power <noel.power@suse.com>
Signed-off-by: Noel Power <noel.power@suse.com>
Signed-off-by: Noel Power <noel.power@suse.com>
Signed-off-by: Noel Power <noel.power@suse.com>
Pull Request Test Coverage Report for Build 722258648
💛 - Coveralls |
✔️ Public Jenkins job #14 successfully finished |
No description provided.