Move network configuration to the 1st stage by default #606
Conversation
teclator
force-pushed
the
network_poc
branch
2 times, most recently
from
5bcc551
to
777d392
Compare
teclator
changed the title
There was a problem hiding this comment.
It looks good. Thanks a lot, because I know this change implies a lot of testing 👏
I only have a minor comment about that #setup_before_proposal method.
On the other hand, I would like to get rid of the references to Yast::Profile (hiding it by now in a #profile method that we can redefine later). But let's keep it simple by now.
| if Yast::Profile.current["networking"] | ||
| if Yast::Profile.current["networking"]["setup_before_proposal"] | ||
| log.info("Networking setup before the proposal") | ||
| Yast::AutoinstConfig.network_before_proposal = true |
There was a problem hiding this comment.
Is the #network_before_proposal method used elsewhere? If that's the case, just keep it as it is. If it is not, I guess we could get rid of it (and use local variable).
There was a problem hiding this comment.
I will check, it was exposed in the past because could be needed by other modules during the autoconfiguration workflow, like for example save_network.
That information is already stored in Lan when the import is done, so probably we could get rid of it.
But maybe we could do it in a second round. So, finishing with the yast2-network changes related to this first stage configuration first and then deciding where to keep that responsibility.
What do you think?
There was a problem hiding this comment.
It was introduced by me in: #347
There was a problem hiding this comment.
OK. Please, make a note somewhere :) and let's continue.
|
✔️ Public Jenkins job #79 successfully finished |
Problem
Historically, AutoYaST has been divided in two stages, doing the installation during the first stage and the configuration during the second.
We have been moving some of the logic to the first stage, but it was still not the default and was only the default when there was no second stage defined.
Solution
Consider the first stage as the default stage for configuring the network. That is, if the
networkingsection is defined in the profile, it will be imported, merging it with the current network config (linuxrc) unless it is specified to not keep the current config (keep_install_network option is defined in the profile as false). Once imported, the section is removed in order to not call thelan_autoclient during the second stage.From here, there are different options that could happen:
The lan_auto client will be called for writing the config
The inst_lan client will be called in order to configure the network
While 1 and 2 steps occurs in
inst_autosetup(https://github.com/yast/yast-autoinstallation/pull/606/files#diff-0100ef44fa49d992794bb1d6b470d681R168), step 3 is done by save_network client in yast2-network (https://github.com/yast/yast-network/blob/master/src/clients/save_network.rb)