don't create grub_installdevice and let perl-Bootloader run grub2-install #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tall The current code uses a quite complex logig to dertermine the grub2 location. And the result is not what storage-ng expects (grub2 installed into mbr). This bypasses the yast-bootloader logic for now until something better can be implemented.
|
well, it is quite big change that need at first to be discussed (as I am not sure if always MBR is something users want and welcome). It also adds again dependency on perl-bootloader, which was dropped in past. |
|
This is just POC code and not intended to be merged (not even for storage-ng). grub2 into MBR is certainly not always the correct idea (say when the disk is shared with other |
|
well, logic on y2-bl is now improved a lot, so lets close this POC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code uses a quite complex logic to determine the grub2
location. And the result is not what storage-ng expects (grub2 installed
into mbr).
This bypasses the yast-bootloader logic for now until something better
can be implemented.