Replace y2base #119
Closed
Replace y2base #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvidner
requested changes
Feb 28, 2017
| /-*/ | ||
| /* | ||
| * Hi. This file is empty on purpose :-) | ||
| * Nice, isn't it? |
There was a problem hiding this comment.
Well, that means we are not really dropping the old code. The old code is in liby2/src/genericfrontend.cc. Why don't we drop that too?
There was a problem hiding this comment.
well, in past it was used also for scr binary. But we probably also no longer use it. So it maybe also make sense to drop it.
mvidner
reviewed
Mar 3, 2017
| Tue Feb 28 15:16:58 UTC 2017 - jreidinger@suse.com | ||
|
|
||
| - Drop y2base binary which is replaced by y2base ruby script from | ||
| yast2-ruby-bindings (bsc#1027181) |
There was a problem hiding this comment.
Also drop the no longer used md_autorun and tty_wrapper.
mvidner
approved these changes
Mar 3, 2017
|
in the end this pr is closed as y2base is still needed for yast2-testsuite. So we will drop it when old testsuite will be dropped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and as bonus drop some unused tools