Fix system namespace #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid
warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
BTW both were honored so they had to be merged in liby2util-r.
Avoid automake warning when bootstrapping
use *.spec file with RPM macros instead - 3.0.2
Ci integration
Because base/src is small, then include test there. If its size increase do not hesitate to split it.
Fix segfault during install
Skip Expect tests if the environment is broken.
Conflicts: VERSION package/yast2-core.changes
Conflicts: .gitignore package/yast2-core.changes
We need different name, because for SystemNamespace we need to call in chrooted env binary that sends there ycp, but scr is already reserved for ScriptingAgent, so it never use ProgramComponent to run in chroot
Reason is that WFMComponent use WFMSubAgent also for local namespace that provide only SystemAgent. So original idea that SubAgent is used only for scr is not valid.
|
What will .changes say? Remember that we discussed this a week ago and I forgot already ;-) |
|
|
Come on, you haven't run
|
|
Now it passed, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it contain also merge of master ( sorry to make review harder...maybe merge master directly in git? )