Ensure ntp is installed (when Install Recommended Packages is off) #55
Conversation
THROW No widget with ID `time_fr It was removed in commit 67b1d81
Moved from yast2-ntp-client:clients/ntp-client_proposal.rb to yast2-country: clients/timezone_ntp.rb because the file provides a part(!) of a dialog for the time settings, and the interface has grown too tangled it does not make sense to keep them in 2 packages/repos. Yes, now the problem has been shifted a level lower, to the NtpClient interface Also, despite being named *_proposal, the client has never been used in the proposal framework. (The original file will be removed from yast2-ntp-client once this package is released)
ntpdate_only -> oneshot (only sync now, not at boot) ntpdate as a program to do the sync was replaced with sntp
The requirement was missing and the package got in thanks to Recommended dependencies. These can now be turned off <https://fate.suse.com/318099>
| def ntp_call(acall, args) | ||
| if !@installed | ||
| # replace "replace_point" by the widgets | ||
| if acall == "ui_init" |
There was a problem hiding this comment.
NP: I know this was simply copied from elsewhere, but using case...when here would really improve it a lot...
|
To be honest, such a big refactoring (although a big part is just code moving) without unit test scares me a bit. |
|
@ancorgs You're right, and the API redesign is not too good either; so I am going to improve that and add tests, but proceed with the actual simple fix in another PR. |
|
@mvidner what is status here? I worry it is too risky for SP1 now, but if you improve it a bit, it can be merged for SP2 |
|
@mvidner SP2 is just behind the door, any progress? |
|
There has not been updates since a while and the bug was already fixed by yast/yast-ntp-client#34 so maybe make sense to close it by now and just create a new PR if some improvements are done at the end. @mvidner , what do you think about? |
https://bugzilla.suse.com/show_bug.cgi?id=938951
The actual fix is 13e61a9 and the rest is refactoring. But the code is spread across two packages (see a related PR in ntp-client) and I am not sure how much of a cleanup I should attempt now (and even if this is in the end a cleanup)