Warn the user about unsaved changes (services selection)

[teclator]

• Trello Card: https://trello.com/c/afBwY7Rc/345-sle-15-ga-as-mu-firewall-ui-support-for-autoyast

UX improvements

[coveralls]

Coverage increased (+0.08%) to 17.54% when pulling e78366d on services_validation into 73cb27e on SLE-15-GA.

[imobachgs]

In general it looks good. Please, fix the changelog.

[imobachgs]

applying

[imobachgs]

np: I am not sure about the term "applying".

[mvidner]

IMHO people will confuse the "applying" with "accepting" the whole module. I would call it "adding", like the button that does it.

Also, we are giving 2 choices:
1: Yes = Switch tabs, discarding the selected services
2: No = Don't switch tabs

But most likely, the user wants to do something different:
3: Switch tabs and Add the services to the Allowed set beforehand.

So I would like to have a choice between 3 and 1, omitting 2 entirely:

The selected services have not yet been added to the allowed set
[Add] [Discard]

[teclator]

IMHO people will confuse the "applying" with "accepting" the whole module. I would call it "adding", like the button that does it.

That is I why I specified "the selection of services", and it is for both actions ("adding" or "removing" services")

Also, we are giving 2 choices:
1: Yes = Switch tabs, discarding the selected services
2: No = Don't switch tabs

But most likely, the user wants to do something different:
3: Switch tabs and Add the services to the Allowed set beforehand.

Yep, I was thinking on this option also, but discarded for not complicate it more.

So I would like to have a choice between 3 and 1, omitting 2 entirely:

The selected services have not yet been added to the allowed set
[Add] [Discard]

In this case, [Apply Changes][Discard] ?

[mvidner]

Ah, you mean [Apply Changes] means to Add the ones in the left column and Remove those in the right column, right? I missed that because the screenshot does not show that complex case.

Well, then [Apply Changes][Discard] is good enough. (We could make it clearer but the code would get too complicated)

[teclator]

Ah, you mean [Apply Changes] means to Add the ones in the left column and Remove those in the right column, right? I missed that because the screenshot does not show that complex case.

Yep, I realized that and that is why I have updated the screenshot, hope it is more clear now.

Well, then [Apply Changes][Discard] is good enough. (We could make it clearer but the code would get too complicated)

Exactly, and in this case I am not sure if we should summarize which services will be added and which ones will be removed.

[teclator]

It seems that [Apply Changes] could be even a nive improvement, as currently you are only allowed to submit one of the list changes (Add or Remove)

[imobachgs]

It seems that [Apply Changes] could be even a nive improvement, as currently you are only allowed to submit one of the list changes (Add or Remove)

Take into account that we took inspiration from the partitioner, so we should keep the same approach (to keep consistency).

[teclator]

It seems that [Apply Changes] could be even a nive improvement, as currently you are only allowed to submit one of the list changes (Add or Remove)

Take into account that we took inspiration from the partitioner, so we should keep the same approach (to keep consistency).

So, what do you suggest?

[teclator]

@imobachgs @mvidner mmm, what about leaving it as it is until we get some feedback from @kwwii

[imobachgs]

So, what do you suggest?

To be honest, I do not have a better alternative. I only mentioned that the "apply" term could be confusing.