Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed translation #7

Merged
merged 1 commit into from
Nov 26, 2014
Merged

fixed translation #7

merged 1 commit into from
Nov 26, 2014

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Nov 12, 2014

Note: #{foo} does not work properly in translated messages, the substitution is done before translating the string, gettext then won't find any translation for it...

@jreidinger
Copy link
Member

LGTM

@mvidner
Copy link
Member

mvidner commented Nov 12, 2014

No, it still does not look good (which is not lslezak's fault).
If we look at the presets we see that :name and :help are initialized with the N_() methods, so I think there may be a translation call missing somewhere.

pgajdos added a commit that referenced this pull request Nov 26, 2014
@pgajdos pgajdos merged commit f43f95e into master Nov 26, 2014
@lslezak lslezak deleted the translation_fix branch November 1, 2016 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants