Drop xinetd (fate#323373) #28
Conversation
src/include/ftp-server/dialogs.rb
Outdated
| fun_ref(method(:"start_via_socket="), "void (boolean)") | ||
| ) | ||
| # TRANSLATORS: Radio selection | ||
| Ops.set(result, "start_auto_button", _("&When booting")) | ||
| Ops.set(result, "start_manual_button", _("&Manually")) | ||
| Ops.set(result, "start_xinetd_button", _("Via &xinetd")) | ||
| Ops.set(result, "start_socket_button", _("Via &socket")) |
There was a problem hiding this comment.
isn't that defaults? so maybe we don't need to set it?
There was a problem hiding this comment.
Yep, probably is not needed, I basically touched because when was testing I was surprised because xinetd button was still there.
Let me check if is something we actually can remove.
Thnx ;)
There was a problem hiding this comment.
@jreidinger I see just differences in the start_auto_button and in start_manual_button. In the last one just the shortcut is not proposed and being "During boot" the one for start_auto_button.
There was a problem hiding this comment.
well, I vote to unify it when possible
There was a problem hiding this comment.
Probably it was done because the call to CWMServiceStart.AutoStartHelpSocketTemplate, as them are independent and you have to specify concretely the labels, so if you modify the defaults them it will be inconsistent again
src/include/ftp-server/dialogs.rb
Outdated
| _("Manually"), | ||
| _("Via Socket") | ||
| _("Via socket") |
There was a problem hiding this comment.
I think if we now use default we should use respective method https://github.com/teclator/yast-yast2/blob/76e0a3280dee002b4b62455eba0f2d35e5b1c2e1/library/cwm/src/modules/CWMServiceStart.rb#L263
this way translators won't need to translate this in different domain.
It depends on yast/yast-yast2#690
There is still some suspicious code mentioning pure-ftpd that probably could be removed (anon_dir permissions and creation) that probably could be dropped, I removed it and was working fine but prefer not touch it if was left there by some reason.