Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FATE#320262 #375

Closed
wants to merge 5 commits into from
Closed

FATE#320262 #375

wants to merge 5 commits into from

Conversation

imobachgs
Copy link
Contributor

  • Implements fate#320262
  • Manually tested faking Arch.is_zkvm method.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 25.975% when pulling c33e796 on imobach:fate-320262 into f1fafc1 on yast:master.

@@ -516,7 +516,7 @@ def main
# and display it, if necessary

# Do not call any SCR, it's already closed!
if Ops.greater_than(Builtins.size(Misc.boot_msg), 0) && !Mode.autoinst
if Ops.greater_than(Builtins.size(Misc.boot_msg), 0)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this change: we must shown the warning about reIPL and it will be skipped in AutoYaST. From my POV, this message should have the same behavior than other messages (if reporting is disabled, it will be skipped).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 25.975% when pulling a6014de on imobach:fate-320262 into f1fafc1 on yast:master.

@imobachgs
Copy link
Contributor Author

Finally it looks like we'll use a different approach. So I'm closing this PR. Check out FATE#320262 for further details.

@imobachgs imobachgs closed this Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants