SSH Importer: Width fix to avoid cut of CheckBoxFrame Label #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| HBox( | ||
| HSpacing(2), | ||
| Left(copy_config_widget) | ||
| MinWidth(50, |
There was a problem hiding this comment.
Obviously, the right fix is to discover why the cut is happening. But, once we are already in the business of workarounds... why don't make it i18n aware with something like...?
label = _("I would like to import SSH keys from a previous installation")
MinWidth(label.length,
...
teclator
force-pushed
the
ssh_import_fix_width
branch
from
b6b9e59
to
444f245
Compare
|
No version increase? |
| HBox( | ||
| HSpacing(2), | ||
| Left(copy_config_widget) | ||
| MinWidth(label.length, |
There was a problem hiding this comment.
Maybe add a comment explaining why this MinWidth is there
teclator
force-pushed
the
ssh_import_fix_width
branch
2 times, most recently
from
451b1ae
to
6d88bf3
Compare
|
LGTM |
teclator
force-pushed
the
ssh_import_fix_width
branch
from
4904802
to
a2fe227
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By some reason the Label of the CheckBoxFrame is being cut. Now width is forced, but could be nice if some UI expert reviewed it as i'm not sure if could be some problem with long texts (translations).
Previously
With MinWidth