Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace y2base #529

Merged
merged 7 commits into from
Apr 7, 2017
Merged

Replace y2base #529

merged 7 commits into from
Apr 7, 2017

Conversation

jreidinger
Copy link
Member

No description provided.

@jreidinger jreidinger mentioned this pull request Feb 22, 2017
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 16.517% when pulling a7ab01f on replace_y2base into 252bad2 on master.

mvidner
mvidner requested changes Feb 28, 2017
View reviewed changes
Copy link
Member

@mvidner mvidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but please add .changes and dependencies to the other parts.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 16.517% when pulling f2a102b on replace_y2base into 252bad2 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 16.998% when pulling 042a742 on replace_y2base into 7e787d9 on master.

mvidner
mvidner requested changes Apr 7, 2017
View reviewed changes
package/yast2-installation.changes Outdated
- update all-in-one's subdialog (network/kdump/partitioning/...)
overview when the dialog is closed and do not lose another
content already entered by user.
>>>>>>> master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cough cough

@coveralls
Copy link

Coverage Status

Coverage remained the same at 16.998% when pulling a6bc7b7 on replace_y2base into 7e787d9 on master.

@jreidinger jreidinger merged commit 3a6fcc0 into master Apr 7, 2017
@jreidinger jreidinger deleted the replace_y2base branch April 7, 2017 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvidner mvidner mvidner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jreidinger @coveralls @mvidner