Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master 1112769 #756

Merged
merged 8 commits into from
Nov 2, 2018
Merged

Master 1112769 #756

merged 8 commits into from
Nov 2, 2018

Conversation

schubi2
Copy link
Member

@schubi2 schubi2 commented Nov 2, 2018

No description provided.

@coveralls
Copy link

coveralls commented Nov 2, 2018

Coverage Status

Coverage remained the same at 21.269% when pulling 1d31efb on master-1112769 into 37ece90 on master.

Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra block

@@ -709,6 +709,16 @@ if [ $SELECTED_MEDIUM = "SSH" ] && [ ! "$VNC" = 1 ];then
# when found the ssh daemon is killed, so create this file as the very last step!!
# (https://github.com/openSUSE/installation-images/blob/c57181329ab7040369da705c5b0ddd78e2960bf0/data/root/etc/inst_setup#L221-L229)
echo $Y2_EXIT_CODE > /tmp/YaST2_ssh_installation_finished
fi

if [ $SELECTED_MEDIUM != "SSH" ] && [ "$Y2_MODE" = "ncurses" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a wrong conflict resolution, the same block is already present below.

@schubi2 schubi2 merged commit edd0018 into master Nov 2, 2018
@schubi2 schubi2 deleted the master-1112769 branch November 2, 2018 15:24
@yast-bot
Copy link
Contributor

yast-bot commented Nov 2, 2018

✔️ Public Jenkins job #27 successfully finished
✔️ Created OBS submit request #646095

@yast-bot
Copy link
Contributor

yast-bot commented Nov 2, 2018

❌ Internal Jenkins job #28 failed

@yast-bot
Copy link
Contributor

yast-bot commented Nov 2, 2018

✔️ Internal Jenkins job #29 successfully finished
✔️ Created IBS submit request #176357

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants