Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide icon with module (boo#1109310) #15

Merged
merged 5 commits into from
Nov 28, 2018
Merged

Provide icon with module (boo#1109310) #15

merged 5 commits into from
Nov 28, 2018

Conversation

hellcp
Copy link
Contributor

@hellcp hellcp commented Nov 25, 2018

No description provided.

Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RPM macro

@@ -63,5 +63,6 @@ used on high availability (HA) clusters.
%{yast_scrconfdir}/*.scr
%doc %{yast_docdir}
%license COPYING
%{_datadir}/icons/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use %{yast_icondir}.

Suggested change
%{_datadir}/icons/*
%{yast_icondir}

Copy link
Member

@lslezak lslezak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak merged commit 47a2a87 into yast:master Nov 28, 2018
@yast-bot
Copy link

✔️ Public Jenkins job #5 successfully finished
✔️ Created OBS submit request #652412

@yast-bot
Copy link

✔️ Internal Jenkins job #5 successfully finished
✔️ Created IBS submit request #178642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants