get rid of autotools #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So what about this: (PR) mvidner@mrakoplas:kdump$ rpm -qlp \
/var/tmp/build-root-openSUSE_Factory/home/abuild/rpmbuild/RPMS/x86_64/yast2-kdump-devel-doc-3.1.19-1.x86_64.rpm
/usr/share/doc/packages/yast2-kdump
/usr/share/doc/packages/yast2-kdump/CONTRIBUTING.md |
|
I have changed the spec to use buildtools. |
|
@mvidner regarding doc subdir, maybe we can add there also generated yardoc which is not generating now |
|
On IRC you said that this did not change. But in fact, before this PR, the subpackage contains the yard docs: $ rpm -qlp /var/tmp/build-root-openSUSE_Factory/home/abuild/rpmbuild/RPMS/x86_64/yast2-kdump-devel-doc-3.1.19-1.x86_64.rpm
/usr/share/doc/packages/yast2-kdump
/usr/share/doc/packages/yast2-kdump/autodocs
/usr/share/doc/packages/yast2-kdump/autodocs/Yast
/usr/share/doc/packages/yast2-kdump/autodocs/Yast.html
/usr/share/doc/packages/yast2-kdump/autodocs/Yast/KdumpClass.html
/usr/share/doc/packages/yast2-kdump/autodocs/Yast/KdumpComplexInclude.html
/usr/share/doc/packages/yast2-kdump/autodocs/Yast/KdumpDialogsInclude.html
/usr/share/doc/packages/yast2-kdump/autodocs/Yast/KdumpHelpsInclude.html
/usr/share/doc/packages/yast2-kdump/autodocs/Yast/KdumpUifunctionsInclude.html
/usr/share/doc/packages/yast2-kdump/autodocs/Yast/KdumpWizardsInclude.html
/usr/share/doc/packages/yast2-kdump/autodocs/_index.html
/usr/share/doc/packages/yast2-kdump/autodocs/class_list.html
/usr/share/doc/packages/yast2-kdump/autodocs/css
/usr/share/doc/packages/yast2-kdump/autodocs/css/common.css
/usr/share/doc/packages/yast2-kdump/autodocs/css/full_list.css
/usr/share/doc/packages/yast2-kdump/autodocs/css/style.css
/usr/share/doc/packages/yast2-kdump/autodocs/file_list.html
/usr/share/doc/packages/yast2-kdump/autodocs/frames.html
/usr/share/doc/packages/yast2-kdump/autodocs/index.html
/usr/share/doc/packages/yast2-kdump/autodocs/js
/usr/share/doc/packages/yast2-kdump/autodocs/js/app.js
/usr/share/doc/packages/yast2-kdump/autodocs/js/full_list.js
/usr/share/doc/packages/yast2-kdump/autodocs/js/jquery.js
/usr/share/doc/packages/yast2-kdump/autodocs/method_list.html
/usr/share/doc/packages/yast2-kdump/autodocs/top-level-namespace.htmlFor a leaf package like this I think the yard docs are useless as a RPM, so we should simply remove the subpackage. |
|
Hmm, some magic, probably in autotools generate it. So is there conclusion to not package it? @lslezak any opinion as I think you add it to autotools |
|
@jreidinger It is not magic. It is part of the cleaned up devtools that you have also worked on. |
Conflicts: .travis.yml
Otherwise this fails: $ rake check:pot /usr/bin/y2tool y2makepot y2tool: Can't find "y2makepot" in /usr/share/YaST2/data/devtools/bin This partially reverts commit 2fa24fd.
|
@lslezak I have updated this rather old PR. JFYI, I think it can wait for Pepa. |
|
@mvidner LGTM for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.