bsc#1045098: Fix regular expression to check alloc_mem parameter #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
reviewed
Jun 21, 2017
test/client_test.rb
Outdated
| context "When using wrong inputs in alloc memory" do | ||
| let(:options) {{"enable"=>"", "alloc_mem"=>"#{alloc_mem_low}:#{alloc_mem_high}"}} | ||
|
|
||
| it "does not enable kdump and return false" do |
mvidner
requested changes
Jun 22, 2017
src/clients/kdump.rb
Outdated
| alloc_mem_low, alloc_mem_high = options["alloc_mem"].split(',') | ||
| Kdump.allocated_memory = { low: alloc_mem_low, high: alloc_mem_high } | ||
| unless alloc_mem_low =~ ALLOC_MEM_REGEXP && | ||
| (alloc_mem_high.nil? || alloc_mem_high =~ ALLOC_MEM_REGEXP) | ||
| CommandLine.Error(_("Invalid allocation memory parameter")) |
There was a problem hiding this comment.
"allocation memory" is wrong, it should be "memory allocation"; but even better, quote the actual parameter name
There was a problem hiding this comment.
Is it better: "alloc_mem parameter used with invalid values" ?
mvidner
approved these changes
Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.