Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for methods of OneClickInstallWorkerFunctions class #25

Merged
merged 3 commits into from
Apr 16, 2021

Conversation

OleksandrOrlov
Copy link
Contributor

The PR adds unit tests for the following methods of OneClickInstallWorkerFunctions class:

  • DeDupe;
  • AddRepositories;
  • RemoveAddedRepositories.

@OleksandrOrlov OleksandrOrlov changed the title Unit tests worker functions Add unit tests for methods of OneClickInstallWorkerFunctions class Jan 28, 2021
@coveralls
Copy link

coveralls commented Jan 28, 2021

Pull Request Test Coverage Report for Build 755855608

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+7.8%) to 12.524%

Totals Coverage Status
Change from base Build 751438960: 7.8%
Covered Lines: 256
Relevant Lines: 2044

💛 - Coveralls

@jknphy
Copy link

jknphy commented Feb 1, 2021

Nice job!, just one suggestion, we could add to #DeDupe the case where nothing is duplicated, the most basic one, if make sense for you.

@OleksandrOrlov OleksandrOrlov force-pushed the unit_tests_worker_functions branch 2 times, most recently from fead43e to 516accf Compare April 16, 2021 13:54
Oleksandr Orlov added 3 commits April 16, 2021 16:00
The commit adds unit tests for DeDupe method of
OneClickInstallWorkerFunctions class.
The commit adds unit tests for AddRepositories method of
OneClickInstallWorkerFunctions class.
The commit adds unit tests for RemoveAddedRepositories method of
OneClickInstallWorkerFunctions class.
Copy link
Member

@jreidinger jreidinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for patch

@jreidinger jreidinger merged commit 22d6c8a into yast:master Apr 16, 2021
@yast-bot
Copy link
Contributor

✔️ Public Jenkins job #14 successfully finished
✔️ Created OBS submit request #886116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants