Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S390 devices activation and better chanids handling #1052

Merged
merged 6 commits into from Apr 2, 2020
Merged

S390 devices activation and better chanids handling #1052

merged 6 commits into from Apr 2, 2020

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Apr 2, 2020 •
edited

This PR fixes two issues:

  • Activation of devices that were already active in S390 systems. It is the network counterpart of [bsc#1163149] Do not activate devices twice yast-s390#81.
  • Allow importing chanids using the spaces or colons as separators. It is preferred to use colons, to be consistent with the lszdev tool, but we need to be backward compatible.

A fix for the documentation will follow.

@coveralls
Copy link

coveralls commented Apr 2, 2020 •
edited

Coverage Status

Coverage increased (+0.2%) to 70.525% when pulling 83994b9 on bsc-1163149/s390-active-devices into 113ed20 on master.

teclator
teclator approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just added some np: comments that can be addressed by a commit and merged if you want to

@imobachgs imobachgs merged commit 61d49c3 into master Apr 2, 2020
@imobachgs imobachgs deleted the bsc-1163149/s390-active-devices branch April 2, 2020 13:02
@yast-bot
Copy link
Contributor

yast-bot commented Apr 2, 2020

✔️ Public Jenkins job #143 successfully finished
✔️ Created OBS submit request #790905

@yast-bot
Copy link
Contributor

yast-bot commented Apr 2, 2020

✔️ Internal Jenkins job #80 successfully finished
✔️ Created IBS submit request #215271

@imobachgs imobachgs mentioned this pull request Apr 2, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teclator teclator teclator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@imobachgs @coveralls @yast-bot @teclator