-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bsc#1163149] Do not activate devices twice #81
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
force-pushed
the
bsc-1163149/s390-active-devices
branch
from
March 31, 2020 13:51
38477c8
to
8201c4e
Compare
imobachgs
force-pushed
the
bsc-1163149/s390-active-devices
branch
from
March 31, 2020 13:55
8201c4e
to
3b45db0
Compare
jreidinger
reviewed
Mar 31, 2020
jreidinger
reviewed
Mar 31, 2020
jreidinger
reviewed
Mar 31, 2020
jreidinger
reviewed
Mar 31, 2020
jreidinger
reviewed
Mar 31, 2020
jreidinger
reviewed
Mar 31, 2020
jreidinger
reviewed
Mar 31, 2020
jreidinger
reviewed
Mar 31, 2020
jreidinger
reviewed
Mar 31, 2020
jreidinger
reviewed
Mar 31, 2020
jreidinger
reviewed
Mar 31, 2020
jreidinger
reviewed
Mar 31, 2020
jreidinger
approved these changes
Apr 2, 2020
✔️ Public Jenkins job #14 successfully finished |
✔️ Internal Jenkins job #7 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements support for kernel activated devices in s390 systems. Until now, AutoYaST took care of activating
zfcp
anddasd
devices. From now on, those devices can be already pre-configured, so AutoYaST should check if they are already activated.This PR skips the activation for:
For the time being, I have decided to simply write a message in the log (the device is activated, so what?). But we can decide to display some kind of message if preferred.
Network related PR: yast/yast-network#1052
Trello: https://trello.com/c/MNlAfnwx/
A simpler approach?
After finishing the PR, I realized that in SP1 (not sure about SP2) the configuration scripts for zFCP devices will not complain about a device being activated twice. Actually, the original bug is caused because we are trying to change the
diag
configuration value of an already activated one.So if this code looks too much, we could simply keep the behavior for DASD devices and ignore zFCP.
TODO