Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bsc#1163149] Do not activate devices twice #81

Merged
merged 14 commits into from
Apr 2, 2020

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Mar 26, 2020

This PR implements support for kernel activated devices in s390 systems. Until now, AutoYaST took care of activating zfcp and dasd devices. From now on, those devices can be already pre-configured, so AutoYaST should check if they are already activated.

This PR skips the activation for:

  • zFCP controllers
  • zFCP disks
  • DASD disks

For the time being, I have decided to simply write a message in the log (the device is activated, so what?). But we can decide to display some kind of message if preferred.

Network related PR: yast/yast-network#1052
Trello: https://trello.com/c/MNlAfnwx/

A simpler approach?

After finishing the PR, I realized that in SP1 (not sure about SP2) the configuration scripts for zFCP devices will not complain about a device being activated twice. Actually, the original bug is caused because we are trying to change the diag configuration value of an already activated one.

So if this code looks too much, we could simply keep the behavior for DASD devices and ignore zFCP.

TODO

  • Handle DASD disks
  • Handle zFCP controllers
  • Handle zFCP LUNs
  • Display a message (or register it on the log)

@coveralls
Copy link

coveralls commented Mar 26, 2020

Coverage Status

Coverage increased (+0.9%) to 8.1% when pulling 04ab854 on bsc-1163149/s390-active-devices into 07fa611 on master.

@imobachgs imobachgs force-pushed the bsc-1163149/s390-active-devices branch from 38477c8 to 8201c4e Compare March 31, 2020 13:51
@imobachgs imobachgs force-pushed the bsc-1163149/s390-active-devices branch from 8201c4e to 3b45db0 Compare March 31, 2020 13:55
@imobachgs imobachgs marked this pull request as ready for review March 31, 2020 13:59
@imobachgs imobachgs merged commit 6fbd6a4 into master Apr 2, 2020
@imobachgs imobachgs deleted the bsc-1163149/s390-active-devices branch April 2, 2020 08:15
@yast-bot
Copy link
Contributor

yast-bot commented Apr 2, 2020

✔️ Public Jenkins job #14 successfully finished
✔️ Created OBS submit request #790803

@yast-bot
Copy link
Contributor

yast-bot commented Apr 2, 2020

✔️ Internal Jenkins job #7 successfully finished
✔️ Created IBS submit request #215244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants