Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Y2Network::Config read which is already read by Yast::Lan.Read #785

Closed
wants to merge 254 commits into from
Closed

Remove Y2Network::Config read which is already read by Yast::Lan.Read #785

wants to merge 254 commits into from

Conversation

teclator
Copy link
Contributor

No description provided.

teclator and others added 30 commits March 18, 2019 17:27
@teclator
Changes based on CR.
6fe3035
@teclator
Merge pull request #732 from yast/cleanup
fc932ac 
Cleanup: Remove dead code and small fixes
@jreidinger
add initial object proposal for dialog routes and gateway cwm widget
8f730b6
@jreidinger
add netmask and also fix gateway
a284cbc
@jreidinger
more widgets
e218d57
@jreidinger
add widget for selected device
81051f4
@imobachgs
Merge pull request #738 from imobachgs/routing-ng
055df6a 
New data model for routing
@jreidinger
Merge remote-tracking branch 'origin/network-ng' into routing_cwm
c33f632
@jreidinger
adapt to new models
62e78d3
@imobachgs
Add a Y2Network::Config writer for :sysconfig
624e5e2
@imobachgs
Minor fixes
0c96f0d
@teclator @mchf
Define the INTERFACETYPE when adding dummy interfaces
66bba48
@teclator @mchf
The script is not available anymore
2ae5017
@teclator @mchf
Removed more dead code
8664333
@teclator @mchf
Bump version & changelog.
ddb7fd9
@teclator @mchf
Changes based on CR.
25c8bb6
@imobachgs @mchf
[PoC] Add routing classes
735ab2f
@imobachgs @mchf
[PoC] Add objects to read configuration from the system
4257ad6
@imobachgs @mchf
Make RuboCop happy
f2e52ed
@imobachgs @mchf
Fix missing Y2Network::Config class
eded6af
@imobachgs @mchf
ConfigReader uses NetworkInterfaces module
f608623
@imobachgs @mchf
Update from code review
57a5495
@imobachgs @mchf
Rename ConfigReader::Wicked to ConfigReader::Sysconfig
ba952ee
@imobachgs @mchf
[WIP] Read routes
1ace623
@imobachgs @mchf
Improve Y2Network::Route to/interface handling in the constructor
e13910c
@imobachgs @mchf
Improve ConfigReader::Sysconfig behaviour
16505fb
@imobachgs @mchf
Update from code review
e25549d
@imobachgs @mchf
Add Y2Network::Config#id
803d7b0
@imobachgs @mchf
Remove (wrong) default value from ConfigReader.for method
2a6a911
@mchf
Polishing documentation
ef749ee
jreidinger and others added 23 commits April 10, 2019 12:36
@jreidinger
fix tests on non-english locale system
3815eea
@imobachgs
Use real objects in RoutingSummary unit tests
98560e4
@imobachgs
Merge pull request #776 from yast/network-ng-fix-gateways-summary
671756c 
network-ng: fix gateways summary and interfaces linking
@teclator
Autoyast Fixes.
ae4a46c
@teclator
Do not touch the summary by now.
8aa7ef3
@teclator
Merge pull request #775 from yast/autoyast_fixes
6363beb 
Autoyast Fixes: Part One
@jreidinger
show ip forwarding even when there is no routes
37457c7
@jreidinger
Merge pull request #778 from yast/fix_summary
8ad727b 
show ip forwarding even when there is no routes
@jreidinger
fix coverage
a54a5fb
@jreidinger
Merge pull request #779 from yast/fix_coverage
122ff2c 
fix coverage
@imobachgs
Drop RoutingTable#concat
556bb65 
* This method is not used anymore.
@imobachgs
Merge pull request #780 from yast/network-ng-drop-concat
90329d9 
Drop the unused Y2Network::RoutingTable#concat
@teclator
Fixed routing export
1f29575
@teclator
Fixed import when no config has been read yet
460f25e
@teclator
Export routing as an empty hash when no present.
85b5219
@teclator
[RFC] Initialize with defaults when no exist. (cache problems)
d10adf8
@teclator
Fixed issue when deleting Item
2ccb276
@teclator
Bring back caching
98d29c4
@teclator
Fixing build of routes when no device is defined.
fde19ab
@teclator
Added unit test for defaults reader
a49a3c0
@teclator
Improving test unit coverage.
aa2a8e0
@teclator
Merge pull request #781 from yast/autoyast_fixes_two
73beed5 
Autoyast fixes two
@teclator
Remove Y2Network::Config read which is already read by Yast::Lan.Read
1a8ae55
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 49.721% when pulling 1a8ae55 on remove_useless_read into 73beed5 on network-ng.

@teclator
Copy link
Contributor Author

This PR is completely out of date, so closing.

@teclator teclator closed this Jun 17, 2019
@teclator teclator deleted the remove_useless_read branch June 17, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchf mchf Awaiting requested review from mchf

@jreidinger jreidinger Awaiting requested review from jreidinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@teclator @coveralls @jreidinger @imobachgs @mchf