Autoyast Fixes: Part One #775
Conversation
src/modules/Lan.rb
Outdated
| presenter.text | ||
| summary = "<ul><li><b>" + _("Routing:") + "</b></li><li>" | ||
| summary += presenter.text | ||
| summary += "</li></ul>" |
There was a problem hiding this comment.
this looks really strange. If you need specific summary for autoinst routing, please create a child of RoutingSummary and redefine text there.
There was a problem hiding this comment.
I just wanted to check how it looked like in the AutoYaST summary, as it was suggested during the network installation proposal review to remove the extra spaces using sublists.
So yes, maybe introducing a ProposalRoutingSummary could be an option.
There was a problem hiding this comment.
hmm, this is really big. I think there is ways to compress like having together IP Forwarding or somehow compress it with less details. This way it is a lot of info that has problem to fit and I worry in ncurses it will be even worse.
There was a problem hiding this comment.
Although this concretely presentation should be responsibility of Yast::Lan Summary
https://github.com/yast/yast-network/blob/master/src/modules/Lan.rb#L813
There was a problem hiding this comment.
Yep, and get bigger with complex configuration
teclator
force-pushed
the
autoyast_fixes
branch
from
747da07
to
8aa7ef3
Compare
| @@ -43,7 +43,7 @@ def initialize(section) | |||
| def config | |||
| interfaces = find_interfaces | |||
| routing = section.routing ? AutoinstRouting.new(section.routing).config : nil | |||
| Y2Network::Config.new(interfaces: interfaces, routing: routing, source: :autoyast) | |||
There was a problem hiding this comment.
The source: :sysconfig instead of :autoinst is a workaround we should discuss. The writer used is based on the source, and that is not the case for AutoYaST. That is, the target writer should be decided based on the current network backend and not based on the source from where the config was read. So basically I used :sysconfig to use its writer.
There was a problem hiding this comment.
makes sense for me to just have backend value in Config.
| @@ -751,7 +751,7 @@ def Import(settings) | |||
| settings = {} if settings.nil? | |||
|
|
|||
| profile = Y2Network::AutoinstProfile::NetworkingSection.new_from_hashes(settings) | |||
| config = Y2Network::Config.from(:autoyast, profile) | |||
| config = Y2Network::Config.from(:autoinst, profile) | |||
There was a problem hiding this comment.
leftover: we renamed the config_reader to Autoinst
Done:
Pending / TODO by Part two: