Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoyast fixes two #781

Merged
merged 9 commits into from
Apr 15, 2019
Merged

Autoyast fixes two #781

merged 9 commits into from
Apr 15, 2019

Conversation

teclator
Copy link
Contributor

@teclator teclator commented Apr 11, 2019 •
edited
Loading

AutoYaST Fixes:

  • Export the section
  • Import when no config has been read yet (Autoyast configuration dialog)

Pending:

  • Autoyast configuration: Routing dialog when empty crashes.

@coveralls
Copy link

coveralls commented Apr 11, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.4%) to 49.715% when pulling aa2a8e0 on autoyast_fixes_two into 90329d9 on network-ng.

jreidinger
jreidinger reviewed Apr 12, 2019
View reviewed changes
src/include/network/services/routing.rb Outdated
@@ -91,19 +91,19 @@ def RoutingMainDialog

def config
# TODO: get it from some config holder
@routing_config ||= Yast::Lan.yast_config
@routing_config = Yast::Lan.yast_config
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variable @routing_config no longer make sense. It can be also removed.

mchf
mchf approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@mchf mchf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@teclator teclator merged commit 73beed5 into network-ng Apr 15, 2019
@teclator teclator deleted the autoyast_fixes_two branch April 15, 2019 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchf mchf mchf approved these changes

@jreidinger jreidinger jreidinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@teclator @coveralls @jreidinger @mchf